CompositeViewer support: Difference between revisions

Jump to navigation Jump to search
m
→‎Status: remove some obsolete comments
m (update as per request by cgdae)
m (→‎Status: remove some obsolete comments)
Line 7: Line 7:


{{Note|While it's certainly possible to have a look at the changes <ref>https://sourceforge.net/p/flightgear/mailman/message/37077854/</ref> and understand how things are working, the code isn't really ready for review and push yet - there's still loads of debug diagnostics and a few dead-ends in there. Jules is hoping to be able to address some of these over the next few days.<ref>https://sourceforge.net/p/flightgear/mailman/message/37077148/</ref>
{{Note|While it's certainly possible to have a look at the changes <ref>https://sourceforge.net/p/flightgear/mailman/message/37077854/</ref> and understand how things are working, the code isn't really ready for review and push yet - there's still loads of debug diagnostics and a few dead-ends in there. Jules is hoping to be able to address some of these over the next few days.<ref>https://sourceforge.net/p/flightgear/mailman/message/37077148/</ref>
In other words: No one is claiming CompositeViewer support is anywhere near being ready to be  enabled by default - there are lots of issues to sort out, at the moment chiefly how to get scenery to show up in cloned views and interact with scenery caching properly etc.  
In other words: No one is claiming CompositeViewer support is anywhere near being ready to be  enabled by default - there are lots of issues to sort out.  
Also, the potential benefits we get with an improved viewing system will be really significant. (For example easy creation at runtime of multiple arbitrary top-level
Also, the potential benefits we get with an improved viewing system will be really significant. (For example easy creation at runtime of multiple arbitrary top-level
windows showing Tower View / Helicopter View etc on one's own or multiplayer aircraft, new dynamic views such as the view from one aircraft to another, etc etc.)
windows showing Tower View / Helicopter View etc on one's own or multiplayer aircraft, new dynamic views such as the view from one aircraft to another, etc etc.)
Line 26: Line 26:
Unfortunately the property system seemed to be not set up early enough to read in FGRenderer's constructor so we do a few calls of fgGetNode("/sim/composite_viewer", true)->getBoolValue() at runtime. Julian suspects they aren't called very frequently, in which case this branch (minus the diagnostics changes probably) might be ok to push to next at
Unfortunately the property system seemed to be not set up early enough to read in FGRenderer's constructor so we do a few calls of fgGetNode("/sim/composite_viewer", true)->getBoolValue() at runtime. Julian suspects they aren't called very frequently, in which case this branch (minus the diagnostics changes probably) might be ok to push to next at
some point, so that it's easier to test/investigate things.<ref>https://sourceforge.net/p/flightgear/mailman/message/37062319/</ref>
some point, so that it's easier to test/investigate things.<ref>https://sourceforge.net/p/flightgear/mailman/message/37062319/</ref>
The previous problem with loading scenery was caused by code using the single View's getFrameStamp(), which appears to be never updated and always has _frameNumber=0. We need to use the CompositeViewer's getFrameStamp() instead.


For some reason buildings don't appear, but basic ground scenery now loads so fgfs progresses to loading the fdm etc and one can fly the aircraft as normal.
For some reason buildings don't appear, but basic ground scenery now loads so fgfs progresses to loading the fdm etc and one can fly the aircraft as normal.
Line 88: Line 86:
{{Multicore}}
{{Multicore}}
-->
-->
== History ==
== History ==


Navigation menu