Canvas scenery overlays: Difference between revisions

Jump to navigation Jump to search
→‎SimGear: archiving PMs
(→‎SimGear: archiving PMs)
Line 390: Line 390:


=== SimGear ===
=== SimGear ===
Hooray has been reviewing the changes that would "break" the [http://wiki.flightgear.org/Photoscenery#Using_photoscenery]old photoscenery patch] (as it can currently be found on the wiki) - and fortunately, it's just a single "recent" refactoring/commit, made by psadro (~18 months ago), one where he split up obj.cxx and moved everything related to the patch to $SG_SRC/scene/tgdb/SGTileGeometryBin.hxx: 148640be3450e34416c77111103f637c451362c8
It seems, this is the main/only thing that no longer applies cleanly - and it's responsible for setting up the overlay coordinates and pass them to the shaders.
So, that's basically what we'd need to review/discuss to re-add the photoscenery functionality so that arbitrary overlays (no matter the concrete use-case) can be added - however, one of the comments in that file mentioned that the method is deprecated, i.e only used by WS 1.0, so I guess psadro would be in the best position to judge if/how to re-introduce that functionality, so that overlays also work with WS 2.0+
Maybe psadro could briefly review the changes, and the patch, and tell us how to best make this work with the more recent WS 2.0 scheme ?
<syntaxhighlight lang="diff">
<syntaxhighlight lang="diff">
</syntaxhighlight>
</syntaxhighlight>

Navigation menu