CompositeViewer support: Difference between revisions

CompositeViewer support (view source)

Revision as of 11:48, 4 August 2020

52 bytes added , 4 August 2020

m

→‎Open Questions

Hooray

Administrators

20,741

edits

Revision as of 11:48, 4 August 2020 (view source) Hooray (talk \| contribs) m (→‎Open Questions) ← Older edit		Revision as of 11:48, 4 August 2020 (view source) Hooray (talk \| contribs) m (→‎Open Questions) Newer edit →
Line 113:		Line 113:
	About this specific feature, there’s one concern: from memory (which may be incorrect), the CompositeViewer changes the OSG multi-threading model significantly, because there are multiple contexts. And since most of our long-standing crashing bugs are around OSG multi-threading, usually in combination with some other feature (eg, particles, or reset), James is not in agreement about the ‘risk free’ nature, if it touches threading at all. But, hopes, if it’s off by default, we can find out.		About this specific feature, there’s one concern: from memory (which may be incorrect), the CompositeViewer changes the OSG multi-threading model significantly, because there are multiple contexts. And since most of our long-standing crashing bugs are around OSG multi-threading, usually in combination with some other feature (eg, particles, or reset), James is not in agreement about the ‘risk free’ nature, if it touches threading at all. But, hopes, if it’s off by default, we can find out.

	James added, he would also be happier if we could get Fernando to do a code review, to make sure we’re not touching anything which might affect the CompositOR<ref>https://sourceforge.net/p/flightgear/mailman/message/37077081/</ref>.		James added, he would also be happier if we could get Fernando to do a code review, to make sure we’re not touching anything which might affect the CompositOR. James also offered to help with reviewing things <ref>https://sourceforge.net/p/flightgear/mailman/message/37077081/</ref>.