FGAddon: Difference between revisions

1,421 bytes added ,  19 September 2015
Shifted the 'Commit access' section under the development section and added some text.
(→‎Aircraft development: Added a section about setting up SourceForge development teams.)
(Shifted the 'Commit access' section under the development section and added some text.)
Line 163: Line 163:
     |author=<nowiki>Curtis Olson</nowiki>
     |author=<nowiki>Curtis Olson</nowiki>
     |date=<nowiki>2014-11-15</nowiki>
     |date=<nowiki>2014-11-15</nowiki>
  }}
}}
== Obtaining Access ==
{{FGCquote
  |About "how I decide who can or can't contribute" it's as simple as this: when someone contact me, I'm looking at who is this person, is it a long term contributor ? is it an active forum member ?
  |{{cite web |url=http://sourceforge.net/p/flightgear/mailman/message/33154193/
    |title=<nowiki>Re: [Flightgear-devel] Wrong commits in FGAddon repository</nowiki>
    |author=<nowiki>Clement de l'Hamaide</nowiki>
    |date=<nowiki>2014-12-16</nowiki>
  }}
}}
{{FGCquote
  |If he is not a long term contributor but an active forum member - "active" mean: a user who is member for long time (more than 3 months) and someone who posted more than 100 posts - I'm checking that this person is aware of how works FlightGear (by reading his posts) and his spirit (it's easy to know if someone is on the same wave or not by reading his posts) is in accordance with the FG spirit (I'm contributing to FlightGear and discussing with long term core dev since more than 4 years now so I can say that I know what is the spirit of FG)
  |{{cite web |url=http://sourceforge.net/p/flightgear/mailman/message/33154193/
    |title=<nowiki>Re: [Flightgear-devel] Wrong commits in FGAddon repository</nowiki>
    |author=<nowiki>Clement de l'Hamaide</nowiki>
    |date=<nowiki>2014-12-16</nowiki>
  }}
}}
{{FGCquote
  |Also, I'm not the only one person who can give commit access, I give "admin" access to the FGAddon repo to 4 persons (Curt, Anders, Gijs, Torsten) so you can be sure that the FGAddon repo is not 'only in my hand' but also in the hand of other persons.
  |{{cite web |url=http://sourceforge.net/p/flightgear/mailman/message/33154193/
    |title=<nowiki>Re: [Flightgear-devel] Wrong commits in FGAddon repository</nowiki>
    |author=<nowiki>Clement de l'Hamaide</nowiki>
    |date=<nowiki>2014-12-16</nowiki>
   }}
   }}
}}
}}
Line 226: Line 198:


To work on the official aircraft collection, you should first set up a [https://sourceforge.net/user/registration/ SourceForge account].  This will allow you to either directly commit to the FGAddon repository, if you have been granted commit access, or to work in as part of a SourceForge development team.
To work on the official aircraft collection, you should first set up a [https://sourceforge.net/user/registration/ SourceForge account].  This will allow you to either directly commit to the FGAddon repository, if you have been granted commit access, or to work in as part of a SourceForge development team.
=== Commit Access ===
Before obtaining commit access, you should contact the original authors to determine if the aircraft is actively being developed.  If so, the aircraft author will direct you as to how to proceed with development.  Otherwise you will need to obtain FGAddon commit access to make the changes.
To obtain commit access, you should first demonstrate you capabilities.  You should sign up for the [https://lists.sourceforge.net/lists/listinfo/flightgear-devel FlightGear development mailing list] and ask for help there.  You should first provide your changes as patches.  If these are not too large, they can be sent as attachments to the mailing list.  For large patches, a [https://sourceforge.net/p/flightgear/codetickets/ code ticket] can be created and the patch attached there, or the patch uploaded to a public server and a link sent in a development mailing list message.
If you are using a subversion command line client, you can create a patch by typing:
<syntaxhighlight lang="bash">
svn diff > my.patch
</syntaxhighlight>
"my.patch" can be any file name.  If you are using a git-svn command line client, type:
<syntaxhighlight lang="bash">
git diff > my.patch
</syntaxhighlight>
Once you have proven your capabilities and you are knowledgeable about GPL licensing issues, you should write a mail to the development mailing list asking if you can be granted commit access, providing your SourceForge username.
{{FGCquote
  |About "how I decide who can or can't contribute" it's as simple as this: when someone contact me, I'm looking at who is this person, is it a long term contributor ? is it an active forum member ?
  |{{cite web |url=http://sourceforge.net/p/flightgear/mailman/message/33154193/
    |title=<nowiki>Re: [Flightgear-devel] Wrong commits in FGAddon repository</nowiki>
    |author=<nowiki>Clement de l'Hamaide</nowiki>
    |date=<nowiki>2014-12-16</nowiki>
  }}
}}
{{FGCquote
  |If he is not a long term contributor but an active forum member - "active" mean: a user who is member for long time (more than 3 months) and someone who posted more than 100 posts - I'm checking that this person is aware of how works FlightGear (by reading his posts) and his spirit (it's easy to know if someone is on the same wave or not by reading his posts) is in accordance with the FG spirit (I'm contributing to FlightGear and discussing with long term core dev since more than 4 years now so I can say that I know what is the spirit of FG)
  |{{cite web |url=http://sourceforge.net/p/flightgear/mailman/message/33154193/
    |title=<nowiki>Re: [Flightgear-devel] Wrong commits in FGAddon repository</nowiki>
    |author=<nowiki>Clement de l'Hamaide</nowiki>
    |date=<nowiki>2014-12-16</nowiki>
  }}
}}
{{FGCquote
  |Also, I'm not the only one person who can give commit access, I give "admin" access to the FGAddon repo to 4 persons (Curt, Anders, Gijs, Torsten) so you can be sure that the FGAddon repo is not 'only in my hand' but also in the hand of other persons.
  |{{cite web |url=http://sourceforge.net/p/flightgear/mailman/message/33154193/
    |title=<nowiki>Re: [Flightgear-devel] Wrong commits in FGAddon repository</nowiki>
    |author=<nowiki>Clement de l'Hamaide</nowiki>
    |date=<nowiki>2014-12-16</nowiki>
  }}
}}


=== SourceForge development team ===
=== SourceForge development team ===